-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-30732: Allows table cells to contain inlines and blocks #56
EZP-30732: Allows table cells to contain inlines and blocks #56
Conversation
a26f93b
to
23ac9fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://tdg.docbook.org/tdg/5.0/html.th.html
This looks legit to me
What is the best way to contact |
Can you provide a sample document that you believe should validate but doesn't? This document validates for me: <article xmlns="http://docbook.org/ns/docbook">
<title>Test</title>
<informaltable>
<tbody>
<tr>
<th>Heading</th>
</tr>
<tr>
<td><para>This is a paragraph.</para>
</td>
</tr>
</tbody>
</informaltable>
</article> |
@ndw can you try to test any block (not inline) element inside the table cell? F.e.
a011b56 is faling without this PR. |
The problem with that example isn't in the table, it's in the <article xmlns="http://docbook.org/ns/docbook">
<title>Test</title>
<informaltable>
<tbody>
<tr>
<th>Heading</th>
</tr>
<tr>
<td><blockquote><para/></blockquote>
</td>
</tr>
</tbody>
</informaltable>
</article> |
@ndw you are correct. After spending more time on this issue, seems like the true reason was found: there was zero width space (
The current PR makes this content valid, and no validation erros are thrown. But, I assume, the more correct solution would be to fix the code which adds zero width space (instead of changing the rng schema). @ndw can you think about any other cases where zero width space might lead to validation errors? |
@vidarl seems like this one might be closed in the flavor of ezsystems/ezplatform-admin-ui@9e8739d |
It took me a few minutes to get my head around this. The XML Recommendation
defines whitespace as explicitly (and exclusively) SPACE ( ), TAB
(	), and NEWLINE (
)[*]. Any other character that occurs between
block elements (including zero-width space, non-breaking space, etc. etc.
etc.) is effectively text where it isn't allowed. A zero-width space where
only elements are allowed is going to cause validation errors every time.
[*] Technically, CARRIAGE RETURN (#xD;) is also part of the space
production, but the parser removes them or converts them to NEWLINE in all
cases except where they occur as explicit numeric character references.
…On Tue, Aug 13, 2019 at 6:25 AM Serhey Dolgushev ***@***.***> wrote:
@vidarl <https://github.com/vidarl> seems like this one might be closed
in the flavor of ***@***.***
<ezsystems/ezplatform-admin-ui@9e8739d>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56?email_source=notifications&email_token=AAAI7OKSJQVVKBZRPGFBJD3QEKKY5A5CNFSM4IKAGMB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4FLOFI#issuecomment-520795925>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAI7OMSLFTKIYW5VAB2GMTQEKKY5ANCNFSM4IKAGMBQ>
.
|
If you're going to insert zero-width spaces sometimes, you might consider
doing it at "​" instead of the literal character. That, at least,
would make the problem easier to find!
…On Tue, Aug 13, 2019 at 7:28 AM Norman Walsh ***@***.***> wrote:
It took me a few minutes to get my head around this. The XML
Recommendation defines whitespace as explicitly (and exclusively) SPACE
( ), TAB (	), and NEWLINE (
)[*]. Any other character that
occurs between block elements (including zero-width space, non-breaking
space, etc. etc. etc.) is effectively text where it isn't allowed. A
zero-width space where only elements are allowed is going to cause
validation errors every time.
[*] Technically, CARRIAGE RETURN (#xD;) is also part of the space
production, but the parser removes them or converts them to NEWLINE in all
cases except where they occur as explicit numeric character references.
On Tue, Aug 13, 2019 at 6:25 AM Serhey Dolgushev ***@***.***>
wrote:
> @vidarl <https://github.com/vidarl> seems like this one might be closed
> in the flavor of ***@***.***
> <ezsystems/ezplatform-admin-ui@9e8739d>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#56?email_source=notifications&email_token=AAAI7OKSJQVVKBZRPGFBJD3QEKKY5A5CNFSM4IKAGMB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4FLOFI#issuecomment-520795925>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAAI7OMSLFTKIYW5VAB2GMTQEKKY5ANCNFSM4IKAGMBQ>
> .
>
|
Yep, this one was fun :) @ndw Thank you a lot for your input! |
1.1
Seems like there is a bug in
doocbook.rng
:The fist condition is always true:
And thats if table cell cotnains any
db.all.blocks
- triggers a validation error:Validation of XML content failed
The most correct fix would be to make this change in
doocbook.rng
.This PR is related to ezsystems/ezplatform-admin-ui#1034.
TODO:
$ composer fix-cs
).